Fix tracking pickling, add worker error reporting #109
+52
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquiroz
reviewed
Oct 22, 2025
| .addConcreteType[EphemerisTracking] | ||
| // Recursive class hierarchy must be built in two steps: | ||
| // https://github.com/suzaku-io/boopickle/blob/master/doc/ClassHierarchies.md#recursive-composite-types | ||
| given trackingPickler: CompositePickler[Tracking] = compositePickler[Tracking] |
There was a problem hiding this comment.
looks odd, don't you get an unused pure expression warning something?
There was a problem hiding this comment.
I guess the next line adding the concrete types to trackigPickler
cquiroz
reviewed
Oct 22, 2025
| case CompositeTracking(nel) => Coordinates.centerOf(nel.map(_.baseCoordinates)) | ||
| case _ => sys.error("Non sidereals are not supported") | ||
|
|
||
| extension [F[_]: MonadThrow: Logger, A](f: F[A]) |
There was a problem hiding this comment.
nice I bet we can use these beyond explore
BundleMon (Explore)Files added (1)
Files updated (2)
Unchanged files (5)
Total files change +1.19KB +0.04% Final result: ✅ View report in BundleMon website ➡️ |
explore/model/shared/src/main/scala/explore/model/extensions.scala
Outdated
Show resolved
Hide resolved
toddburnside
approved these changes
Oct 22, 2025
…cala Co-authored-by: Todd Burnside <tburnside@gemini.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursive picklers must be built in 2 steps.